Adopt FFI #10221
Adopt FFI #10221
Conversation
# Conflicts: # src/google/protobuf/compiler/java/message_serialization.cc
…ementation of FFI. Code cleanup: fix indentation and some other sources of spurious warnings.
…mbol, unlike rb_define_const, so skip its invocation after warning.
… present in Ruby.
…ger a dependency.
…can find the native extension.
…etween Ruby and JRuby. Preserves distinct conformance test expectations, even though Ruby and JRuby are currently identical.
Includes minor build file fixes and tweaks to avoid warnings when running tests.
|
This PR passes all tests again. @mkruskal-google for review of changes to Bazel-ization. |
|
It looks like this PR is proposing to migrate all of JRuby and CRuby to FFI. We cannot migrate CRuby until we have validated the performance. Do you have performance numbers? Last we talked my understanding was that this regresses CRuby significantly. |
|
It turns out that all performance was significantly negatively impacted by the same issue that was causing memory corruption. Now that has been addressed, I think there is a more compelling case for a general migration. I can post the numbers here or share them with you when I see you later this week. |
|
Closing this PR in favor of #11483 |
Opening this PR in order to get visibility on any potential Kokoro issues introduced by the branch.